flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5884) Integrate time indicators for Table API & SQL
Date Fri, 05 May 2017 00:13:06 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997634#comment-15997634
] 

ASF GitHub Bot commented on FLINK-5884:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3808#discussion_r114904005
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
    @@ -37,7 +38,50 @@ class StreamTableSourceScan(
       extends PhysicalTableSourceScan(cluster, traitSet, table, tableSource)
       with StreamScan {
     
    -  override def computeSelfCost(planner: RelOptPlanner, metadata: RelMetadataQuery): RelOptCost
= {
    +  override def deriveRowType() = {
    +    val flinkTypeFactory = cluster.getTypeFactory.asInstanceOf[FlinkTypeFactory]
    +
    +    def removeIndex[T](idx: Int, l: List[T]): List[T] = {
    --- End diff --
    
    Can be done with `List.patch(idx, Nil, 1)`


> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
>                 Key: FLINK-5884
>                 URL: https://issues.apache.org/jira/browse/FLINK-5884
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators (event-time
or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we can solve
this issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message