flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5884) Integrate time indicators for Table API & SQL
Date Thu, 04 May 2017 07:54:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996312#comment-15996312
] 

ASF GitHub Bot commented on FLINK-5884:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3808#discussion_r114697132
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
---
    @@ -150,3 +133,30 @@ case class WindowReference(name: String) extends Attribute {
         }
       }
     }
    +
    +abstract class TimeAttribute(val expression: Expression)
    +  extends UnaryExpression
    +  with NamedExpression {
    +
    +  override private[flink] def child: Expression = expression
    +
    +  override private[flink] def name: String = expression match {
    +    case UnresolvedFieldReference(name) => name
    +    case _ => throw new ValidationException("Unresolved field reference expected.")
    +  }
    +
    +  override private[flink] def toAttribute: Attribute =
    +    throw new UnsupportedOperationException("Time attribute can not be used solely.")
    +}
    +
    +case class RowtimeAttribute(expr: Expression) extends TimeAttribute(expr) {
    +
    +  override private[flink] def resultType: TypeInformation[_] =
    +    TimeIndicatorTypeInfo.ROWTIME_INDICATOR
    +}
    +
    +case class ProctimeAttribute(expr: Expression) extends TimeAttribute(expr) {
    --- End diff --
    
    I think the `expr` of `ProctimeAttribute` should not be a physical field, Because we never
use the value of physical field. e.g: we can not using `ProctimeAttribute` as follow:
    `//data  (1L, 1, "Hello"),
    env.fromCollection(data).toTable(tEnv, 'a, 'b, 'c.proctime)`
    What do you think?


> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
>                 Key: FLINK-5884
>                 URL: https://issues.apache.org/jira/browse/FLINK-5884
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators (event-time
or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we can solve
this issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message