flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions
Date Tue, 02 May 2017 09:38:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992633#comment-15992633
] 

ASF GitHub Bot commented on FLINK-5488:
---------------------------------------

GitHub user fanyon opened a pull request:

    https://github.com/apache/flink/pull/3805

    [FLINK-5488] stop YarnClient before exception is thrown

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fanyon/flink FLINK-5488

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3805
    
----
commit 2205f7782650a1031d1284f75691966646784c31
Author: mengji.fy <mengji.fy@taobao.com>
Date:   2017-05-02T09:10:44Z

    [FLINK-5488] stop YarnClient before exception is thrown

----


> yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-5488
>                 URL: https://issues.apache.org/jira/browse/FLINK-5488
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>            Reporter: Ted Yu
>            Assignee: Fang Yong
>
> Here is one example:
> {code}
>     if(jobManagerMemoryMb > maxRes.getMemory() ) {
>       failSessionDuringDeployment(yarnClient, yarnApplication);
>       throw new YarnDeploymentException("The cluster does not have the requested resources
for the JobManager available!\n"
>         + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " + jobManagerMemoryMb
+ "MB. " + NOTE);
>     }
> {code}
> yarnClient implements Closeable.
> It should be closed in situations where exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message