flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins
Date Thu, 04 May 2017 14:39:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996818#comment-15996818

ASF GitHub Bot commented on FLINK-5256:

Github user DmytroShkvyra commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/generated.scala
    @@ -35,7 +35,11 @@ case class GeneratedExpression(
         resultTerm: String,
         nullTerm: String,
         code: String,
    -    resultType: TypeInformation[_])
    +    resultType: TypeInformation[_]) {
    +  var leftNullTerm: String = _
    --- End diff --
    @fhueske It doesn't work because `${codeGenerator.input1Term}` is Row
    `        @Override
            public void join(Object _in1, Object _in2, org.apache.flink.util.Collector c)
throws Exception {
              org.apache.flink.types.Row in1 = (org.apache.flink.types.Row) _in1;
              org.apache.flink.types.Row in2 = (org.apache.flink.types.Row) _in2;`
    But I need know which field in join expression is null

> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Dmytro Shkvyra
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary inner joins
where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and right joins
with single input. These cases can be handled if the  {{DataSetSingleRowJoin}} is extended
to support outer joins on the non-single-row input, i.e., left joins if the right side is
single input and vice versa.

This message was sent by Atlassian JIRA

View raw message