flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pattarawat Chormai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2032) Migrate integration tests from temp output files to collect()
Date Wed, 03 May 2017 11:21:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994682#comment-15994682
] 

Pattarawat Chormai commented on FLINK-2032:
-------------------------------------------

Hi [~fhueske],

As shown in my previous comment, there are several tests still using temporary directory.
So, I would like to work on this and wonder whether I should create subtasks for that or work
directly on this issue.

Best,
Pat

> Migrate integration tests from temp output files to collect()
> -------------------------------------------------------------
>
>                 Key: FLINK-2032
>                 URL: https://issues.apache.org/jira/browse/FLINK-2032
>             Project: Flink
>          Issue Type: Task
>          Components: Tests
>    Affects Versions: 0.9
>            Reporter: Fabian Hueske
>            Assignee: Pattarawat Chormai
>            Priority: Minor
>              Labels: starter
>
> Most of Flink's integration tests that execute full Flink programs and check their results
are implemented by writing results to temporary output file and comparing the content of the
file to a provided set of expected Strings. Flink's test utils make this quite comfortable
and hide a lot of the complexity of this approach. Nonetheless, this approach has a few drawbacks:
> - increased latency by going through disk
> - comparison is on String representation of objects
> - depends on the file system
> Since Flink's {{collect()}} feature was added, the temp file approach is not the best
approach anymore. Instead, tests can collect the result of a Flink program directly as objects
and compare these against a set of expected objects.
> It would be good to migrate the existing test base to use {{collect()}} instead of temporary
output files.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message