flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3989: [FLINK-6719] Activate strict checkstyle for flink-...
Date Thu, 25 May 2017 18:54:30 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3989#discussion_r118558312
  
    --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java
---
    @@ -369,68 +372,87 @@ public static void main(String[] args) throws Exception {
     					.fieldDelimiter("\t").types(Long.class, Long.class);
     
     			DataSet<Tuple2<Long, Long>> result = input.map(
    -					new MapFunction<Tuple2<Long,Long>, Tuple2<Long,Long>>() {
    +					new MapFunction<Tuple2<Long, Long>, Tuple2<Long, Long>>() {
     						public Tuple2<Long, Long> map(Tuple2<Long, Long> value){
    -							return new Tuple2<Long, Long>(value.f0, value.f1+1);
    +							return new Tuple2<Long, Long>(value.f0, value.f1 + 1);
     						}
     					});
     			result.writeAsCsv(args[1], "\n", "\t");
     			env.execute();
     		}
    +
     		@Override
     		public String getDescription() {
     			return "TestOptimizerPlan <input-file-path> <output-file-path>";
     		}
     	}
     
    +	/**
    +	 * That job that calls {@link ExecutionEnvironment#execute()} twice.
    --- End diff --
    
    will fix it while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message