flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #3945: [FLINK-6634] [cep] NFASerializer serializes Comput...
Date Fri, 19 May 2017 13:16:42 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3945#discussion_r117477471
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -930,6 +930,7 @@ public void serialize(NFA<T> record, DataOutputView target)
throws IOException {
     				timestampSerializer.serialize(computationState.getTimestamp(), target);
     				versionSerializer.serialize(computationState.getVersion(), target);
     				timestampSerializer.serialize(computationState.getStartTimestamp(), target);
    +				target.writeInt(computationState.getCounter());
    --- End diff --
    
    The `counter` field was introduced in Flink 1.3 and the new serializer is only used in
Flink 1.3. Before it was Java Serialization, so if you see in the `readComputationState()`
we create a computation state with 0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message