flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options
Date Thu, 18 May 2017 12:47:48 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3935#discussion_r117237209
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
---
    @@ -92,7 +92,7 @@ public static FailureRateRestartStrategyFactory createFactory(Configuration
conf
     		String failuresIntervalString = configuration.getString(
     				ConfigConstants.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL, Duration.apply(1,
TimeUnit.MINUTES).toString()
     		);
    -		String timeoutString = configuration.getString(ConfigConstants.AKKA_WATCH_HEARTBEAT_INTERVAL,
ConfigConstants.DEFAULT_AKKA_ASK_TIMEOUT);
    --- End diff --
    
    @tillrohrmann Is it intended that the default for `AKKA_WATCH_HEARTBEAT_INTERVAL` is inherently
tied to `DEFAULT_AKKA_ASK_TIMEOUT`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message