flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3919: [FLINK-6583][talbe]Enable QueryConfig in count bas...
Date Thu, 18 May 2017 08:05:28 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
    @@ -245,6 +264,7 @@ object DataStreamGroupWindowAggregate {
         case SlidingGroupWindow(_, timeField, size, slide)
             if isProctimeAttribute(timeField) && isRowCountLiteral(size) =>
           stream.countWindow(toLong(size), toLong(slide))
    +      .trigger(StateCleaningCountTrigger.of(queryConfig, toLong(slide)));
    --- End diff --
    `slide` is correct here (check `KeyedStream.countWindow(long, long)`).
    The default trigger is replaced by a trigger that additional registers a clean up timer.
The trigger policy based on counts is still the same.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message