flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...
Date Thu, 18 May 2017 07:19:43 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3915#discussion_r117175607
  
    --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
    @@ -171,6 +170,11 @@ public FlinkKafkaConsumer09(List<String> topics, KeyedDeserializationSchema<T>
d
     	}
     
     	@Override
    +	public FlinkKafkaConsumerBase<T> setStartFromSpecificDate(Date date) {
    +		throw new RuntimeException("This method dose not support for version 0.8 of Kafka");
    --- End diff --
    
    Do you mean 0.9? Also, typo on "dose".
    I would also suggest to be more specific: "Starting from a specific date is not supported
for Kafka version xx".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message