flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #3928: [FLINK-6608] [security, config] Relax Kerberos log...
Date Thu, 18 May 2017 01:43:43 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3928#discussion_r117146767
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
    @@ -230,10 +230,15 @@ private void validate() {
     		}
     
     		private static List<String> parseList(String value) {
    -			if(value == null) {
    +			if(value == null || value.isEmpty()) {
     				return Collections.emptyList();
     			}
    -			return Arrays.asList(value.split(","));
    +
    +			return Arrays.asList(value
    +				.replaceAll("\\s*,\\s*", ",") // remove whitespaces surrounding commas
    +				.replaceAll(",,", ",") // remove empty entries
    --- End diff --
    
    Hi, @tzulitai `.replaceAll("\\s*,\\s*", ",").replaceAll(",,", ",") ` can not deal with
`" a, b,,, c d, e "`
    I think we can using the expression as follows:
     `str.trim().replaceAll("(\\s*,+\\s*)+", ",")` OR `str.replace("/^\\s+|\\s+$/g","").replaceAll("(\\s*,\\s*)+",
",");`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message