flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3919: [FLINK-6583][talbe]Enable QueryConfig in count bas...
Date Wed, 17 May 2017 08:14:30 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/triggers/StateCleaningCountTrigger.scala
    @@ -19,44 +19,46 @@ package org.apache.flink.table.runtime.triggers
     import java.lang.{Long => JLong}
    +import org.apache.flink.annotation.PublicEvolving
     import org.apache.flink.api.common.functions.ReduceFunction
     import org.apache.flink.api.common.state._
     import org.apache.flink.streaming.api.windowing.triggers.Trigger.TriggerContext
     import org.apache.flink.streaming.api.windowing.triggers.{Trigger, TriggerResult}
    -import org.apache.flink.streaming.api.windowing.windows.Window
    +import org.apache.flink.streaming.api.windowing.windows.GlobalWindow
     import org.apache.flink.table.api.{StreamQueryConfig, Types}
    -import org.apache.flink.table.runtime.triggers.CountTriggerWithCleanupState.Sum
    +import org.apache.flink.table.runtime.triggers.StateCleaningCountTrigger.Sum
    -class CountTriggerWithCleanupState[W <: Window](queryConfig: StreamQueryConfig, maxCount:
    -  extends Trigger[Any, W] {
    +  * A {@link Trigger} that fires once the count of elements in a pane reaches the given
    +  * or the cleanup timer is triggered.
    +  */
    --- End diff --
    We only annotate classes the core, DataSet and DataStream APIs with stability annotations.
    `@PublicEvolving` should be removed.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message