flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3919: [FLINK-6583][talbe]Enable QueryConfig in count bas...
Date Tue, 16 May 2017 13:34:07 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3919#discussion_r116727685
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
    @@ -245,6 +266,8 @@ object DataStreamGroupWindowAggregate {
         case SlidingGroupWindow(_, timeField, size, slide)
             if isProctimeAttribute(timeField) && isRowCountLiteral(size) =>
           stream.countWindow(toLong(size), toLong(slide))
    +      .evictor(CountEvictor.of(toLong(size)))
    --- End diff --
    
    Do we need to override the evictor as well? 
    I think it should not be changed if we add a custom trigger.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message