flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...
Date Tue, 16 May 2017 08:04:23 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3915#discussion_r116675159
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
    @@ -290,10 +296,30 @@ public FlinkKafkaConsumerBase(List<String> topics, KeyedDeserializationSchema<T>
     	public FlinkKafkaConsumerBase<T> setStartFromGroupOffsets() {
     		this.startupMode = StartupMode.GROUP_OFFSETS;
     		this.specificStartupOffsets = null;
    +		this.specificStartupDate = null;
     		return this;
     	}
     
     	/**
    +	 * Specifies the consumer to start reading partitions from specific date. The specified
date must before curr timestamp.
    +	 * This lets the consumer ignore any committed group offsets in Zookeeper / Kafka brokers.
    +	 *
    +	 * The consumer will look up the earliest offset whose timestamp is greater than or
equal to the specific date from the kafka.
    --- End diff --
    
    the kafka --> just "Kafka", with K capitalized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message