flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tedyu <...@git.apache.org>
Subject [GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...
Date Mon, 15 May 2017 21:58:26 GMT
Github user tedyu commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
    @@ -318,9 +318,10 @@ public void addVirtualSideOutputNode(Integer originalId, Integer
virtualId, Outp
    -			if (!tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
    -				throw new IllegalArgumentException("Trying to add a side input for the same id "
    -						"with a different type. This is not allowed.");
    +			if (tag.f1.getId().equals(outputTag.getId()) &&
    +					!tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
    +				throw new IllegalArgumentException("Trying to add a side output for the same" +
    --- End diff --
    minor: missing space after "same"

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message