flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink issue #3851: [FLINK-6462] [table] Add requiresOver interface for Aggre...
Date Fri, 12 May 2017 16:38:08 GMT
Github user sunjincheng121 commented on the issue:

    Hi @fhueske, Thanks for the reviewing. 
    I forgot to run the `mvn verify` at the first time. Sorry for that.:(
    I had update the PR. according your comments. Except one,i.e.:
    Move `scala/batch/table/AggregationsTest.scala#testOverAggregation` to `AggregationsValidationTest`.
Because `AggregationsTest` should extends `TableTestBase`. And `AggregationsValidationTest`
need not.
    What do you think?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message