flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...
Date Fri, 12 May 2017 12:50:04 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3851#discussion_r116211558
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
    @@ -53,8 +54,17 @@ class DataSetAggregateRule
     
         // check if we have distinct aggregates
         val distinctAggs = agg.getAggCallList.exists(_.isDistinct)
    +    if (distinctAggs) {
    +      throw TableException("DISTINCT aggregates are currently not supported.")
    +    }
    +
    +    // check if we have over aggregates
    +    val overAggs = agg.getAggCallList.exists(_.getAggregation.requiresOver())
    +    if (overAggs) {
    +      throw TableException("OVER clause is necessary for requires over window functions")
    --- End diff --
    
    Same for the other checks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message