flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shixiaogang <...@git.apache.org>
Subject [GitHub] flink pull request #3870: [Flink 6537] Fixes and improvements for incrementa...
Date Fri, 12 May 2017 06:42:36 GMT
Github user shixiaogang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3870#discussion_r116161230
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalKeyedStateHandle.java
---
    @@ -180,69 +176,66 @@ public long getStateSize() {
     
     	@Override
     	public void registerSharedStates(SharedStateRegistry stateRegistry) {
    +
     		Preconditions.checkState(!registered, "The state handle has already registered its
shared states.");
     
    -		for (Map.Entry<String, StreamStateHandle> newSstFileEntry : newSstFiles.entrySet())
{
    -			SstFileStateHandle stateHandle = new SstFileStateHandle(newSstFileEntry.getKey(),
newSstFileEntry.getValue());
    +		for (Map.Entry<String, StreamStateHandle> newSstFileEntry : unregisteredSstFiles.entrySet())
{
    --- End diff --
    
    I think it's better to rename `newSstFileEntry`to `unregisteredSstFileEntry`. What do
you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message