flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3715: [FLINK-6232][Table&SQL]Support proctime inner equi...
Date Wed, 10 May 2017 23:25:12 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
    @@ -698,6 +698,12 @@ class CodeGenerator(
               s"void join(Object _in1, Object _in2, org.apache.flink.util.Collector $collectorTerm)",
               List(s"$inputTypeTerm1 $input1Term = ($inputTypeTerm1) _in1;",
                    s"$inputTypeTerm2 $input2Term = ($inputTypeTerm2) _in2;"))
    +      } else if (clazz == classOf[FilterFunction[_]]) {
    --- End diff --
    Not needed if we use `JoinFunction` instead of `FilterFunction`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message