flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alpinegizmo <...@git.apache.org>
Subject [GitHub] flink pull request #3858: [FLINK-6513][docs] cleaned up some typos and gramm...
Date Wed, 10 May 2017 09:52:40 GMT
Github user alpinegizmo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3858#discussion_r115699196
  
    --- Diff: docs/dev/best_practices.md ---
    @@ -284,30 +284,30 @@ Change your projects `pom.xml` file like this:
     
     The following changes were done in the `<dependencies>` section:
     
    - * Exclude all `log4j` dependencies from all Flink dependencies: This causes Maven to
ignore Flink's transitive dependencies to log4j.
    - * Exclude the `slf4j-log4j12` artifact from Flink's dependencies: Since we are going
to use the slf4j to logback binding, we have to remove the slf4j to log4j binding.
    + * Exclude all `log4j` dependencies from all Flink dependencies: this causes Maven to
ignore Flink's transitive dependencies to log4j.
    + * Exclude the `slf4j-log4j12` artifact from Flink's dependencies: since we are going
to use the slf4j to logback binding, we have to remove the slf4j to log4j binding.
      * Add the Logback dependencies: `logback-core` and `logback-classic`
    - * Add dependencies for `log4j-over-slf4j`. `log4j-over-slf4j` is a tool which allows
legacy applications which are directly using the Log4j APIs to use the Slf4j interface. Flink
depends on Hadoop which is directly using Log4j for logging. Therefore, we need to redirect
all logger calls from Log4j to Slf4j which is in turn logging to Logback.
    + * Add dependencies for `log4j-over-slf4j`. `log4j-over-slf4j` is a tool which allows
legacy applications which are directly using the Log4j APIs to use the Slf4j interface. Flink
depends on Hadoop which is directly using Log4j for logging. Therefore we need to redirect
all logger calls from Log4j to Slf4j which is in turn logging to Logback.
    --- End diff --
    
    That was a mistake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message