flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #3599: [FLINK-6174][HA]introduce a SMARTER leader latch to make ...
Date Mon, 08 May 2017 18:44:45 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3599
  
    Thanks for adding this!
    I have a few questions:
    
      - From the formatting, the code looks like might be adapted from some other project.
If yes, can you share from where and add a comment above the code that it is adopted from
another project. Also, formatting in the common Flink style would be good.
    
      - The HA leader election is very critical, so we usually don't just replace code that
has worked well (for many users with new code that we have not extensively tested. Therefore,
I suggest to add a config option to activate this smarter latch, thus making it optional for
users that want to use it initially.
    
      - Once this proves stable, we can make it the default in the next version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message