flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #3833: [FLINK-6221] Add PrometheusReporter
Date Sat, 06 May 2017 17:01:51 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3833
  
    I've glanced over this for now but it looks pretty good.
    
    If possible though i would like to not use the DropwizardExports class, for 2 reasons:
    
    1) We now introduce this odd pattern of extending `ScheduledDropwizardReporter` without
actually being scheduled nor creating an actual Dropwizard reporter.
    
    2) I've looked into the source code and it has the typical Dropwizard reporter problem
where absolutely nothing gets cached and effectively constant objects are re-created again
and again. We can make this way more efficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message