flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #3808: [FLINK-5884] [table] Integrate time indicators for...
Date Fri, 05 May 2017 03:06:08 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
    @@ -150,3 +133,30 @@ case class WindowReference(name: String) extends Attribute {
    +abstract class TimeAttribute(val expression: Expression)
    +  extends UnaryExpression
    +  with NamedExpression {
    +  override private[flink] def child: Expression = expression
    +  override private[flink] def name: String = expression match {
    +    case UnresolvedFieldReference(name) => name
    +    case _ => throw new ValidationException("Unresolved field reference expected.")
    +  }
    +  override private[flink] def toAttribute: Attribute =
    +    throw new UnsupportedOperationException("Time attribute can not be used solely.")
    +case class RowtimeAttribute(expr: Expression) extends TimeAttribute(expr) {
    --- End diff --
    1. Not allow `TimeAttribute` make sense for me. +1
    2. Forbidden `proctime` on existing field that's I want to see.+1
    3. About ` rowtime `on existing attribute,I'am not sure. But I think in a Stream environment,
If we want query the `rowtime` column, It should be a physical field. And if only a indicators
of time mode. I think It should not be a physical field. Because there is no place to apply
this value. I had left a question to @twalthr in first review summary. So I want to know @twalthr
's opinion? :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message