flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #3808: [FLINK-5884] [table] Integrate time indicators for...
Date Fri, 05 May 2017 01:24:44 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3808#discussion_r114920160
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
    @@ -194,7 +194,30 @@ abstract class BatchTableEnvironment(
       protected def registerDataSetInternal[T](
           name: String, dataSet: DataSet[T], fields: Array[Expression]): Unit = {
     
    -    val (fieldNames, fieldIndexes) = getFieldInfo[T](dataSet.getType, fields)
    +    val (fieldNames, fieldIndexes) = getFieldInfo[T](
    +      dataSet.getType,
    +      fields,
    +      ignoreTimeAttributes = true)
    +
    +    // validate and extract time attributes
    +    val (rowtime, proctime) = validateAndExtractTimeAttributes(fieldNames, fieldIndexes,
fields)
    +
    +    // don't allow proctime on batch
    +    proctime match {
    --- End diff --
    
    In fact, In batch mode we only support `event-time`, And the the column that represents
the `rowtime` is not an indicators but a real exist field. We only care about the data type
of the field,So IMO. we can not using both `.proctime` and `.rowtime` in batch mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message