flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3808: [FLINK-5884] [table] Integrate time indicators for...
Date Fri, 05 May 2017 00:12:18 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3808#discussion_r114783322
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
    @@ -774,6 +798,42 @@ abstract class TableEnvironment(val config: TableConfig) {
         Some(mapFunction)
       }
     
    +  /**
    +    * Checks for at most one rowtime and proctime attribute.
    +    * Returns the time attributes.
    +    *
    +    * @return rowtime attribute and proctime attribute
    +    */
    +  protected def validateAndExtractTimeAttributes(
    --- End diff --
    
    Can be moved to `StreamTableEnvironment` if we do not allow `TimeAttribute`s in batch
environments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message