flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3808: [FLINK-5884] [table] Integrate time indicators for...
Date Fri, 05 May 2017 00:12:18 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/DefinedTimeAttributes.scala
    @@ -0,0 +1,47 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.sources
    +import org.apache.flink.api.java.tuple.Tuple2
    +  * Defines logical time attributes for a [[TableSource]]. Time attributes can be used
    +  * indicating, accessing, and working with Flink's event-time or processing-time. A
    +  * [[TableSource]] that implements this interface can define names and positions of
    +  * and proctime attributes in the rows it produces.
    +  */
    +trait DefinedTimeAttributes {
    +  /**
    +    * Defines a name and position (starting at 0) of rowtime attribute that represents
    +    * event-time. Null if no rowtime should be available. If the position is within the
arity of
    +    * the result row, the logical attribute will overwrite the physical attribute. If
the position
    +    * is higher than the result row, the time attribute will be appended logically.
    +    */
    +  def getRowtimeAttribute: Tuple2[Int, String]
    --- End diff --
    I don't think we need to offer the option to override the an attribute for TableSources.
They can modify the schema themselves and return the data without the actual time attribute.

    So `getRowtimeAttribute` would just define the name of the logical attribute.
    Same for proctime.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message