flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From godfreyhe <...@git.apache.org>
Subject [GitHub] flink pull request #3569: [flink-6036]Let catalog support partition
Date Thu, 04 May 2017 04:07:56 GMT
Github user godfreyhe commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3569#discussion_r114697342
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
    @@ -44,6 +43,8 @@ case class ExternalCatalogTable(
         properties: JMap[String, String] = new JHashMap(),
         stats: TableStats = null,
         comment: String = null,
    +    partitionColumnNames: JLinkedHashSet[String] = new JLinkedHashSet(),
    +    isPartitioned: Boolean = false,
    --- End diff --
    
    add comments for ``partitionColumnNames`` and ``isPartitioned``


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message