flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #3801: [FLINK-6364] [checkpoints] Implement incremental c...
Date Tue, 02 May 2017 17:32:58 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3801#discussion_r114368960
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
    @@ -137,6 +156,14 @@
     	/** Number of bytes required to prefix the key groups. */
     	private final int keyGroupPrefixBytes;
     
    +	/** The sst files materialized in pending checkpoints */
    +	private final SortedMap<Long, Map<String, StreamStateHandle>> materializedSstFiles
= new TreeMap<>();
    +
    +	/** The identifier of the last completed checkpoint */
    +	private final long lastCompletedCheckpointId = -1;
    --- End diff --
    
    Currently, this value `lastCompletedCheckpointId` is not maintained at all, and also the
`materializedSstFiles` is ever-growing. I think the whole feedback from the checkpoint coordinator
about completed checkpoints is still missing. Are you planning to do this in another PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message