Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: ramkrish86 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-3760-flink@git.apache.org>
Subject: [GitHub] flink pull request #3760: FLINK-5752 Support push down projections for HBase...
Content-Type: text/plain
Date: Mon, 24 Apr 2017 10:36:52 +0000 (UTC)
archived-at: Mon, 24 Apr 2017 10:36:58 -0000

GitHub user ramkrish86 opened a pull request:

    https://github.com/apache/flink/pull/3760

    FLINK-5752 Support push down projections for HBaseTableSource (Ram)

    Ran mvn clean verify -DskipTests
    In this patch 
    `Arrays.sort(nestedFields[i]);`
    
    Am doing this before doing addColumns for the new projected table source, because here the cols appears in a reverse sorted way and when we apply that for the new projected table source it creates an assertion error while creating the new calcite program with the projected cols
    `assert expr.getType().getFieldList().get(field.getIndex()) == field;`
    So doing this sort helps in correcting those issues and the tests run fine. But this nestedFields that is being passed to the projectNestedFields() API is created by
    `def getProjectedFields: Array[Array[String]] ` under RexProgramExtractor. Trying to understand what it does. 
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-5752

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3760
    
----
commit 1885b0c9afc7aa49747987b0508ba82002a1bc8d
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2017-04-24T10:23:08Z

    FLINK-5752 Support push down projections for HBaseTableSource (Ram)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---