Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 28 Apr 2017 01:34:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13065373.1492653322000.74053.1493343244948@Atlassian.JIRA>
In-Reply-To: <JIRA.13065373.1492653322000@Atlassian.JIRA>
References: <JIRA.13065373.1492653322000@Atlassian.JIRA> <JIRA.13065373.1492653322341@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6334) Refactoring UDTF interface
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 28 Apr 2017 01:34:10 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6334?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1598=
8013#comment-15988013 ]=20

ASF GitHub Bot commented on FLINK-6334:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3791#discussion_r113833504
 =20
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/t=
able/api/TableEnvironment.scala ---
    @@ -107,6 +107,11 @@ abstract class TableEnvironment(val config: TableC=
onfig) {
       // registered external catalog names -> catalog
       private val externalCatalogs =3D new HashMap[String, ExternalCatalog=
]
    =20
    +  private lazy val tableFunctionParser =3D new TableFunctionParser(thi=
s)
    +
    +  // the method for converting a udtf String to Table for Java API
    +  final def tableApply(udtf: String): Table =3D tableFunctionParser(ud=
tf)
    --- End diff --
   =20
    `TableFunctionParser` only has one method named `apply`. IMO. It's a ut=
il method. So here are 3 suggestions:
    * If a class only contains util methods, I suggest change `class` to `o=
bject`, And tableEnv can be a param of method.
    * If `TableFunctionParser#apply` only used for `TableFunction`, I sugge=
st move `apply` method into `UserDefinedFunctionUtils` ,Because all of the =
functional methods of `UDF/UDTF/UDAF` in that file.
    * if the method only used for `TableEnvironment`.Whether it can be impl=
emented internally in `TableEnvironment` =EF=BC=9F
    What do you think? @Xpray=20


> Refactoring UDTF interface
> --------------------------
>
>                 Key: FLINK-6334
>                 URL: https://issues.apache.org/jira/browse/FLINK-6334
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> The current UDTF leverages the table.join(expression) interface, which is=
 not a proper interface in terms of semantics. We would like to refactor th=
is to let UDTF use table.join(table) interface. Very briefly,  UDTF's apply=
 method will return a Table Type, so Join(UDTF('a, 'b, ...) as 'c) shall be=
 viewed as join(Table)


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)