Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 17 Apr 2017 09:04:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13061172.1491236248000.295048.1492419881617@Atlassian.JIRA>
In-Reply-To: <JIRA.13061172.1491236248000@Atlassian.JIRA>
References: <JIRA.13061172.1491236248000@Atlassian.JIRA> <JIRA.13061172.1491236248734@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6257) Post-pass OVER windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 17 Apr 2017 09:04:46 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970882#comment-15970882 ] 

ASF GitHub Bot commented on FLINK-6257:
---------------------------------------

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3697
  
    @zentol Thank you for the reminder. And I added some change messages.
    Thanks,
    SunJincheng


> Post-pass OVER windows
> ----------------------
>
>                 Key: FLINK-6257
>                 URL: https://issues.apache.org/jira/browse/FLINK-6257
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: sunjincheng
>            Priority: Critical
>
> The OVER windows have been implemented by several contributors.
> We should do a post pass over the contributed code and improve a few things.
> * Functionality
> ** Currently every time attribute is allowed as ORDER BY attribute. We must check that this is actually a time indicator ({{procTime()}}, {{rowTime()}}) and that the order is ASCENDING.
> * Documentation
> ** Add documentation for OVER windows
> * Code style
> ** Consistent naming of {{ProcessFunctions}} and methods
> * Tests
> ** Move the OVER window tests out of SqlITCase into a dedicated class
> ** Move the OVER window tests out of WindowAggregateTest into a dedicated class
> ** Add tests based on the test harness for all {{ProcessFunctions}} similar to {{BoundedProcessingOverRangeProcessFunction}}. The tests should include exact boundary checks for range windows and check for proper parallelization with multiple keys.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)