Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 7 Apr 2017 11:11:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13061172.1491236248000.234338.1491563501685@Atlassian.JIRA>
In-Reply-To: <JIRA.13061172.1491236248000@Atlassian.JIRA>
References: <JIRA.13061172.1491236248000@Atlassian.JIRA> <JIRA.13061172.1491236248734@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6257) Post-pass OVER windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 07 Apr 2017 11:11:47 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6257?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1596=
0614#comment-15960614 ]=20

ASF GitHub Bot commented on FLINK-6257:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/3697

    [FLINK-6257][table]Optimize test cases

    Thanks for contributing to Apache Flink. Before you open your pull requ=
est, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open y=
our pull request. For more information and/or questions please refer to the=
 [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful desc=
ription of your changes.
   =20
    - [] General
      - The pull request references the related JIRA issue ("[FLINK-6257][t=
able]Optimize test cases")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including th=
e JIRA id)
   =20
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
   =20
    - [=C3=97] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Trav=
is build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6257-PR-Tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3697
   =20
----
commit 4ff7af2ea11eb78a945243d234b0a1a6b4624fcc
Author: sunjincheng121 <sunjincheng121@gmail.com>
Date:   2017-04-06T07:33:50Z

    [FLINK-6257][table]Optimize test cases

----


> Post-pass OVER windows
> ----------------------
>
>                 Key: FLINK-6257
>                 URL: https://issues.apache.org/jira/browse/FLINK-6257
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: sunjincheng
>            Priority: Critical
>
> The OVER windows have been implemented by several contributors.
> We should do a post pass over the contributed code and improve a few thin=
gs.
> * Functionality
> ** Currently every time attribute is allowed as ORDER BY attribute. We mu=
st check that this is actually a time indicator ({{procTime()}}, {{rowTime(=
)}}) and that the order is ASCENDING.
> * Documentation
> ** Add documentation for OVER windows
> * Code style
> ** Consistent naming of {{ProcessFunctions}} and methods
> * Tests
> ** Move the OVER window tests out of SqlITCase into a dedicated class
> ** Move the OVER window tests out of WindowAggregateTest into a dedicated=
 class
> ** Add tests based on the test harness for all {{ProcessFunctions}} simil=
ar to {{BoundedProcessingOverRangeProcessFunction}}. The tests should inclu=
de exact boundary checks for range windows and check for proper paralleliza=
tion with multiple keys.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)