Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3673-flink@git.apache.org>
In-Reply-To: <git-pr-3673-flink@git.apache.org>
Subject: [GitHub] flink pull request #3673: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...
Content-Type: text/plain
Message-Id: <20170427104953.B88F1E04B1@git1-us-west.apache.org>
Date: Thu, 27 Apr 2017 10:49:53 +0000 (UTC)
archived-at: Thu, 27 Apr 2017 10:49:58 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3673#discussion_r113663600
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala ---
    @@ -369,10 +363,258 @@ class JoinITCase(
         val table = CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv).as('a1, 'a2, 'a3)
         tEnv.registerTable("A", table)
     
    -    val sqlQuery1 = "SELECT * FROM A CROSS JOIN (SELECT count(*) FROM A HAVING count(*) < 0)"
    --- End diff --
    
    The previous result was correct and should not be changed.
    Doing a cross join against an empty table results in an empty table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---