Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: bowenli86 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3736-flink@git.apache.org>
In-Reply-To: <git-pr-3736-flink@git.apache.org>
Subject: [GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter
Content-Type: text/plain
Message-Id: <20170418204837.B1487DFCA1@git1-us-west.apache.org>
Date: Tue, 18 Apr 2017 20:48:37 +0000 (UTC)
archived-at: Tue, 18 Apr 2017 20:48:42 -0000

Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/3736
  
    Great advice. Thanks, @zentol !  
    
    My questions to your suggestions:
    1. If I make DatadogHttpReport implement MetricReporter interface, shall I just ignore Histogram and Meter which are not supported by Datadog Http API and document that?
    2. For creating DGauges/DCounters. I believe you are correct. I can create new objects upon metrics registration, and continue update their values, right?
    3. About parsing tags. Great to know I can do it via MetricGroup! Thus, shall I just document the metrics scope configs should be as the following? 
    
    ```
    metrics.scope.jm: jobmanager
    metrics.scope.jm.job: jobmanager.job
    metrics.scope.tm: taskmanager
    metrics.scope.tm.job: taskmanager.job
    metrics.scope.task: task
    metrics.scope.operator: operator
    ```
    

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---