Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: lincoln-lil <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3733-flink@git.apache.org>
In-Reply-To: <git-pr-3733-flink@git.apache.org>
Subject: [GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...
Content-Type: text/plain
Message-Id: <20170418135751.77223E2F42@git1-us-west.apache.org>
Date: Tue, 18 Apr 2017 13:57:51 +0000 (UTC)
archived-at: Tue, 18 Apr 2017 13:58:02 -0000

Github user lincoln-lil commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r111959829
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/RetractionITCase.scala ---
    @@ -0,0 +1,310 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.api.scala.stream
    +
    +import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
    +import org.apache.flink.table.api.{TableEnvironment, TableException}
    +import org.apache.flink.table.api.scala.stream.utils.{StreamITCase, StreamingWithStateTestBase}
    +import org.apache.flink.types.Row
    +import org.junit.Assert._
    +import org.junit.Test
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.api.scala._
    +import org.apache.flink.streaming.api.TimeCharacteristic
    +import org.apache.flink.table.utils.TableFunc0
    +
    +import scala.collection.mutable
    +
    +/**
    +  * tests for retraction
    +  */
    +class RetractionITCase extends StreamingWithStateTestBase {
    +  // input data
    +  val data = List(
    +    ("Hello", 1),
    +    ("word", 1),
    +    ("Hello", 1),
    +    ("bark", 1)
    +  )
    +
    +  // keyed groupby + keyed groupby
    +  @Test
    +  def testWordCount(): Unit = {
    +    val env = StreamExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env)
    +    StreamITCase.testResults = mutable.MutableList()
    +    env.setParallelism(1)
    +    env.setStateBackend(getStateBackend)
    +
    +    val stream = env.fromCollection(data)
    +    val table = stream.toTable(tEnv, 'word, 'num)
    +    val resultTable = table
    +      .groupBy('word)
    +      .select('word as 'word, 'num.sum as 'count)
    +      .groupBy('count)
    +      .select('count, 'word.count as 'frequency)
    +
    +    val results = resultTable.toDataStream[Row]
    +    results.addSink(new StreamITCase.StringSink)
    +    env.execute()
    +
    +    val expected = Seq("1,1", "1,2", "1,1", "2,1", "1,2")
    +    assertEquals(expected.sorted, StreamITCase.testResults.sorted)
    +  }
    +
    +  // keyed groupby + non-keyed groupby
    +  @Test
    +  def testGroupByAndNonKeyedGroupBy(): Unit = {
    +
    +    val env = StreamExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env)
    +    StreamITCase.testResults = mutable.MutableList()
    +    env.setParallelism(1)
    +    env.setStateBackend(getStateBackend)
    +
    +    val stream = env.fromCollection(data)
    +    val table = stream.toTable(tEnv, 'word, 'num)
    +    val resultTable = table
    +      .groupBy('word)
    +      .select('word as 'word, 'num.sum as 'count)
    +      .select('count.sum)
    +
    +    val results = resultTable.toDataStream[Row]
    +    results.addSink(new StreamITCase.StringSink)
    +    env.execute()
    +
    +    val expected = Seq("1", "2", "1", "3", "4")
    --- End diff --
    
    Could you explain this example?
    table.groupBy('word).select('word as 'word, 'num.sum as 'count)
    I think this query does not produce retraction


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---