flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhijiangW <...@git.apache.org>
Subject [GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...
Date Thu, 27 Apr 2017 03:03:49 GMT
GitHub user zhijiangW opened a pull request:


    [FLINK-6337][network] Remove the buffer provider from PartitionRequestServerHandler

    Currently, `PartitionRequestServerHandler` will create a `LocalBufferPool` when the channel
is registered. The `LocalBufferPool` is only used to get segment size for creating read view
in `SpillableSubpartition`, and the buffers in the pool will not be used all the time, so
it will waste the buffer resource of global pool.
    We would like to remove the `LocalBufferPool` from the `PartitionRequestServerHandler`,
and the `LocalBufferPool` in `ResultPartition` can also provide the segment size for creating
sub partition view.
    This modification will not effect the current behavior and will get benefits of saving
buffer resources.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhijiangW/flink FLINK-6337

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3785
commit 306f32414eabce5522ec2a8883aa27285e6aa3e4
Author: Zhijiang <wangzhijiang999@aliyun.com>
Date:   2017-04-26T08:18:54Z

    [FLINK-6337][network] Remove the buffer provider from PartitionRequestServerHandler


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message