flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3774: [FLINK-6384] [py] Remove python binary check via a...
Date Tue, 25 Apr 2017 18:45:29 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3774

    [FLINK-6384] [py] Remove python binary check via additional process

    The PythonStreamer used to check for the existence of the python binary by
    starting a python process. This process was not closed afterwards. This caused
    the PythonPlanBinderTest to fail locally.
    
    I think the check whether a python binary exists is not necessary since the
    subsequent python command would fail anyway if there is no binary available on
    the system. The system failure message is that there is no such file or directory.
    This error message should be descriptive enough in order to debug such a problem.
    
    cc @zentol

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixPythonStreamer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3774
    
----
commit 746fe59737338c02502443c5c3e88c613d0b92ad
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-04-25T18:41:58Z

    [FLINK-6384] [py] Remove python binary check via additional process
    
    The PythonStreamer used to check for the existence of the python binary by
    starting a python process. This process was not closed afterwards. This caused
    the PythonPlanBinderTest to fail locally.
    
    I think the check whether a python binary exists is not necessary since the
    subsequent python command would fail anyway if there is no binary available on
    the system. The system failure message is that there is no such file or directory.
    This error message should be descriptive enough in order to debug such a problem.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message