flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6395) TestBases not marked as abstract
Date Fri, 28 Apr 2017 09:19:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988491#comment-15988491
] 

ASF GitHub Bot commented on FLINK-6395:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3790
  
    As you can see in the `UnaryOperatorTestBase` the constructor is already protected. The
thing is that junit complains since the classes contain junit annotations (`@After`, `@Parameterized`)
class but can't be instantiated. When i run these test in IntelliJ they are marked as failed
tests due to an initialization error.
    
    Making the classes abstract makes it clear they aren't actually self-contained test classes.


> TestBases not marked as abstract
> --------------------------------
>
>                 Key: FLINK-6395
>                 URL: https://issues.apache.org/jira/browse/FLINK-6395
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.3.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>
> The following test base classes don't contain any test methods and should be marked as
abstract:
> BinaryOperatorTestBase
> DriverTestBase
> UnaryOperatorTestBase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message