flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6367) support custom header settings of allow origin
Date Tue, 25 Apr 2017 16:16:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983135#comment-15983135
] 

ASF GitHub Bot commented on FLINK-6367:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3769#discussion_r113241231
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -1333,6 +1333,11 @@
     		key("jobmanager.web.address")
     			.noDefaultValue();
     
    +	/** Web response header of Access-Control-Allow-Origin's key and default value. */
    +	public static final ConfigOption<String> JOB_MANAGER_WEB_ACCESS_CONTROL_ALLOW_ORIGIN
=
    +		key("jobmanager.web.access-control-allow-origin").defaultValue("*");
    --- End diff --
    
    please move `.defaultValue("*")` into a new line.


> support custom header settings of allow origin
> ----------------------------------------------
>
>                 Key: FLINK-6367
>                 URL: https://issues.apache.org/jira/browse/FLINK-6367
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Webfrontend
>            Reporter: shijinkui
>            Assignee: shijinkui
>
> `jobmanager.web.access-control-allow-origin`: Enable custom access control parameter
for allow origin header, default is `*`.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message