flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler
Date Fri, 28 Apr 2017 14:38:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988920#comment-15988920
] 

ASF GitHub Bot commented on FLINK-6337:
---------------------------------------

Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3785#discussion_r113945018
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java
---
    @@ -68,7 +68,6 @@ public void testSuccessfulProgramAfterFailure() {
     	
     			try {
     				runKMeans(cluster.getLeaderRPCPort());
    -				fail("This program execution should have failed.");
    --- End diff --
    
    Yes, I misunderstand this test and you get the key point.


> Remove the buffer provider from PartitionRequestServerHandler
> -------------------------------------------------------------
>
>                 Key: FLINK-6337
>                 URL: https://issues.apache.org/jira/browse/FLINK-6337
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>
> Currently, {{PartitionRequestServerHandler}} will create a {{LocalBufferPool}} when the
channel is registered. The {{LocalBufferPool}} is only used to get segment size for creating
read view in {{SpillableSubpartition}}, and the buffers in the pool will not be used all the
time, so it will waste the buffer resource of global pool.
> We would like to remove the {{LocalBufferPool}} from the {{PartitionRequestServerHandler}},
and the {{LocalBufferPool}} in {{ResultPartition}} can also provide the segment size for creating
sub partition view.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message