flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency
Date Tue, 18 Apr 2017 11:50:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972539#comment-15972539
] 

ASF GitHub Bot commented on FLINK-6295:
---------------------------------------

Github user WangTaoTheTonic commented on the issue:

    https://github.com/apache/flink/pull/3709
  
    @zentol No you're wrong.
    
    If you take a look at `ExecutionGraphHolder`, you'll find the graphs in it are generated
from message answered by JobManager, which means there's no reference from JobManager but
only from handlers in netty web backend. Once there's no reference from those handlers, they
would be garbage collected no matter the actual job is running or recovering.


> use LoadingCache instead of WeakHashMap to lower latency
> --------------------------------------------------------
>
>                 Key: FLINK-6295
>                 URL: https://issues.apache.org/jira/browse/FLINK-6295
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>            Reporter: Tao Wang
>            Assignee: Tao Wang
>
> Now in ExecutionGraphHolder, which is used in many handlers, we use a WeakHashMap to
cache ExecutionGraph(s), which is only sensitive to garbage collection.
> The latency is too high when JVM do GC rarely, which will make status of jobs or its
tasks unmatched with the real ones.
> LoadingCache is a common used cache implementation from guava lib, we can use its time
based eviction to lower latency of status update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message