flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6275) Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster
Date Sun, 16 Apr 2017 06:41:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970256#comment-15970256

ASF GitHub Bot commented on FLINK-6275:

GitHub user zhangminglei opened a pull request:


    [FLINK-6275] [yarn] Fix unprotected access to resourceManage in YarnF…

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink_6275

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3724
commit f0c6971538673930bbca9a9e00ee53d4a26e972c
Author: rice.zhang <rice.zhang@vipshop.com>
Date:   2017-04-16T06:38:22Z

    [FLINK-6275] [yarn] Fix unprotected access to resourceManage in YarnFlinkApplicationMasterRunner.


> Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster
> ----------------------------------------------------------------------------------------------
>                 Key: FLINK-6275
>                 URL: https://issues.apache.org/jira/browse/FLINK-6275
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Minor
> {code}
>       // wait for resource manager to finish
>       resourceManager.getTerminationFuture().get();
> {code}
> The above is outside synchronized block.
> @GuardedBy indicates that access should be protected.

This message was sent by Atlassian JIRA

View raw message