flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction
Date Wed, 05 Apr 2017 21:35:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957755#comment-15957755
] 

ASF GitHub Bot commented on FLINK-6241:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3676#discussion_r110031845
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
    @@ -239,6 +241,212 @@ class CodeGenerator(
       }
     
       /**
    +    * Generates a [[org.apache.flink.table.runtime.aggregate.AggregateHelper]] that can
be passed
    +    * to Java compiler.
    +    *
    +    * @param name       Class name of the Function. Must not be unique but has to be
a valid Java
    +    *                   class identifier.
    +    * @param clazz      AggregateHelper Function to be generated.
    +    * @param aggFields  position (in the input Row) of the input value for each aggregate
    +    * @param aggregates List of all aggregate functions
    +    * @param generator  code generator instance
    +    * @param inputType  Input row type
    +    *
    +    * @tparam F Flink Function to be generated.
    +    * @return instance of GeneratedFunction
    +    */
    +  def generateAggregateHelper[F <: Function](
    --- End diff --
    
    rename to `generateAggregations`?


> codeGen dataStream aggregates that use ProcessFunction
> ------------------------------------------------------
>
>                 Key: FLINK-6241
>                 URL: https://issues.apache.org/jira/browse/FLINK-6241
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message