flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction
Date Mon, 17 Apr 2017 20:23:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971601#comment-15971601
] 

ASF GitHub Bot commented on FLINK-6240:
---------------------------------------

Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3694#discussion_r111813245
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
    @@ -792,6 +792,20 @@ object AggregateUtil {
             inputType,
             needRetraction = false)
     
    +    val forwardMapping = (0 until inputType.getFieldCount).map(x => (x, x)).toArray
    --- End diff --
    
    Thanks @fhueske , I have addressed your comments, please take a look.


> codeGen dataStream aggregates that use AggregateAggFunction
> -----------------------------------------------------------
>
>                 Key: FLINK-6240
>                 URL: https://issues.apache.org/jira/browse/FLINK-6240
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message