flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6149) add additional flink logical relation nodes
Date Mon, 03 Apr 2017 11:59:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953344#comment-15953344
] 

ASF GitHub Bot commented on FLINK-6149:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3594#discussion_r109395373
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/cost/FlinkRelMdRowCount.scala
---
    @@ -23,13 +23,17 @@ import org.apache.calcite.util.BuiltInMethod
     import org.apache.flink.table.plan.nodes.dataset.{DataSetCalc, DataSetSort}
     import java.lang.Double
     
    +import org.apache.flink.table.rel.logical.FlinkLogicalCalc
    +
     object FlinkRelMdRowCount extends RelMdRowCount {
     
    -    val SOURCE: RelMetadataProvider = ReflectiveRelMetadataProvider.reflectiveSource(
    -      BuiltInMethod.ROW_COUNT.method,
    -      this)
    +  val SOURCE: RelMetadataProvider = ReflectiveRelMetadataProvider.reflectiveSource(
    +    BuiltInMethod.ROW_COUNT.method,
    +    this)
    +
    +  def getRowCount(rel: FlinkLogicalCalc, mq: RelMetadataQuery): Double = rel.estimateRowCount(mq)
    --- End diff --
    
    Can we change this to `def getRowCount(rel: Calc, mq: RelMetadataQuery): Double` to cover
`DataSetCalc` and `FlinkLogicalCalc` or would that be too generic?


> add additional flink logical relation nodes
> -------------------------------------------
>
>                 Key: FLINK-6149
>                 URL: https://issues.apache.org/jira/browse/FLINK-6149
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kurt Young
>            Assignee: Kurt Young
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message