flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mingleizhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held
Date Wed, 19 Apr 2017 02:35:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973937#comment-15973937
] 

mingleizhang commented on FLINK-6130:
-------------------------------------

[~Zentol] [~till.rohrmann] That makes sense to me now. So, I just have decided that the previous
practice {code}Object result = future.value().get();{code} is meaningless as I can not any
useful message from it. Thanks and appreciate it.

> Consider calling resourceManager#getTerminationFuture() with lock held
> ----------------------------------------------------------------------
>
>                 Key: FLINK-6130
>                 URL: https://issues.apache.org/jira/browse/FLINK-6130
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Minor
>
> In YarnFlinkApplicationMasterRunner#runApplicationMaster() :
> {code}
>       synchronized (lock) {
>         LOG.info("Starting High Availability Services");
> ...
>       }
>       // wait for resource manager to finish
>       resourceManager.getTerminationFuture().get();
> {code}
> resourceManager#getTerminationFuture() is called without holding lock.
> We should store the value returned from resourceManager#getTerminationFuture() inside
the synchronized block.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message