flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter
Date Fri, 21 Apr 2017 06:10:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978120#comment-15978120
] 

ASF GitHub Bot commented on FLINK-6013:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3736#discussion_r112613622
  
    --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.metrics.datadog;
    +
    +import com.fasterxml.jackson.core.JsonProcessingException;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import okhttp3.MediaType;
    +import okhttp3.OkHttpClient;
    +import okhttp3.Request;
    +import okhttp3.Response;
    +import okhttp3.RequestBody;
    +
    +import java.io.IOException;
    +import java.util.concurrent.TimeUnit;
    +
    +/**
    + * Http client talking to Datadog
    + * */
    +public class DatadogHttpClient{
    +	private static final String SERIES_URL_FORMAT = "https://app.datadoghq.com/api/v1/series?api_key=%s";
    +	private static final String VALIDATE_URL_FORMAT = "https://app.datadoghq.com/api/v1/validate?api_key=%s";
    +	private static final MediaType MEDIA_TYPE = MediaType.parse("application/json; charset=utf-8");
    +	private static final int TIMEOUT = 3;
    +	private static final ObjectMapper MAPPER = new ObjectMapper();
    +
    +	private final String seriesUrl;
    +	private final String validateUrl;
    +	private final OkHttpClient client;
    +	private final String apiKey;
    +
    +	public DatadogHttpClient(String dgApiKey) {
    +		if(dgApiKey == null || dgApiKey.isEmpty()) {
    --- End diff --
    
    missing space after if


> Add Datadog HTTP metrics reporter
> ---------------------------------
>
>                 Key: FLINK-6013
>                 URL: https://issues.apache.org/jira/browse/FLINK-6013
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.3.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Critical
>             Fix For: 1.3.0
>
>
> We at OfferUp use Datadog a lot for metrics and dashboards, and I believe a lot other
companies also do.
> Flink right now only has a StatsD metrics reporter, and users have to set up Datadog
Agent in order to receive metrics from StatsD and transport them to Datadog. We don't like
this approach.
> We prefer to have a Datadog metrics reporter directly contacting Datadog http endpoint.
> I'll take this ticket myself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message