flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3
Date Wed, 26 Apr 2017 19:07:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985381#comment-15985381
] 

ASF GitHub Bot commented on FLINK-5969:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3778#discussion_r113435697
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
---
    @@ -489,6 +489,39 @@ public JobExecutionResult retrieveJob(JobID jobID) throws JobExecutionException
     	}
     
     	/**
    +	 * Reattaches to a running from from the supplied job id
    +	 *
    +	 * @param jobID The job id of the job to attach to
    +	 * @return The JobExecutionResult for the jobID
    +	 * @throws JobExecutionException if an error occurs during monitoring the job execution
    +	 */
    +	public JobListeningContext connectToJob(JobID jobID) throws JobExecutionException {
    +		final LeaderRetrievalService leaderRetrievalService;
    +		try {
    +			leaderRetrievalService = LeaderRetrievalUtils.createLeaderRetrievalService(flinkConfig);
    +		} catch (Exception e) {
    +			throw new JobRetrievalException(jobID, "Could not create the leader retrieval service",
e);
    +		}
    +
    +		ActorGateway jobManagerGateway;
    +		try {
    +			jobManagerGateway = getJobManagerGateway();
    +		} catch (Exception e) {
    +			throw new JobRetrievalException(jobID, "Could not retrieve the JobManager Gateway");
    --- End diff --
    
    Include the exception


> Add savepoint backwards compatibility tests from 1.2 to 1.3
> -----------------------------------------------------------
>
>                 Key: FLINK-5969
>                 URL: https://issues.apache.org/jira/browse/FLINK-5969
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.3.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> We currently only have tests that test migration from 1.1 to 1.3, because we added these
tests when releasing Flink 1.2.
> We have to copy/migrate those tests:
>  - {{StatefulUDFSavepointMigrationITCase}}
>  - {{*MigrationTest}}
>  - {{AbstractKeyedCEPPatternOperator}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message