flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "lining (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5957) Remove `getAccumulatorType` method from build-in `AggregateFunction`
Date Thu, 20 Apr 2017 11:19:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976502#comment-15976502
] 

lining commented on FLINK-5957:
-------------------------------

Hi, [~sunjincheng121] 
I think `TypeInformation.of(new TypeHint[AGG.type](){})` is not ok, because use java clazz.getGenericSuperclass(),
so type lost, but `org.apache.flink.streaming.api.scala.createTypeInformation[AGG.type]` is
ok, you can try it


> Remove  `getAccumulatorType` method from build-in `AggregateFunction`
> ---------------------------------------------------------------------
>
>                 Key: FLINK-5957
>                 URL: https://issues.apache.org/jira/browse/FLINK-5957
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Build-in aggregateFunction need not implement the  `getAccumulatorType` method. 
> We can get TypeInformation by  `TypeInformation.of() ` or `TypeInformation.of(new TypeHint[AGG.type](){})`.

> What do you think? [~fhueske] [~shaoxuan] 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message