flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5545) Remove FlinkAggregateExpandDistinctAggregatesRule when upgrading to Calcite 1.12
Date Fri, 07 Apr 2017 09:53:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960563#comment-15960563

ASF GitHub Bot commented on FLINK-5545:

GitHub user KurtYoung opened a pull request:


    [FLINK-5545] [table] Remove FlinkAggregateExpandDistinctAggregatesRul…

    …e after bumping Calcite to v1.12.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KurtYoung/flink flink-5545

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3695
commit 2d8c740852e56cbc54120acea234975771171a66
Author: Kurt Young <ykt836@gmail.com>
Date:   2017-04-07T09:46:06Z

    [FLINK-5545] [table] Remove FlinkAggregateExpandDistinctAggregatesRule after bumping Calcite
to v1.12.


> Remove FlinkAggregateExpandDistinctAggregatesRule when upgrading to Calcite 1.12
> --------------------------------------------------------------------------------
>                 Key: FLINK-5545
>                 URL: https://issues.apache.org/jira/browse/FLINK-5545
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Zhenghua Gao
>            Assignee: Kurt Young
>            Priority: Minor
> We copy calcite's AggregateExpandDistinctAggregatesRule to Flink project, and do a quick
fix to avoid some bad case mentioned in CALCITE-1558.
> Should drop it and use calcite's AggregateExpandDistinctAggregatesRule when we upgrade
to calcite 1.12(above)

This message was sent by Atlassian JIRA

View raw message